Repository navigation
refactor(support): share the result-to-array reading of the intake, permit, capacity and advice services - #5867
Closed
rubenvdlinde wants to merge 2 commits into
Closed
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
… capacity and advice services Assisted-by: ClaudeCode:claude-opus-5-5
…ermit, capacity and advice services Six more classes carried the jsonSerialize-only reading under other names (normalize, normalizeToArray, arrayOf, asArray, objectAsArray). Each now delegates to Support\SerialisedArray::of(), added here with the same content as in the sibling changes so any of them can merge first. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 11, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #5885.
The static helper added here repeated the reading
SearchesObjectsalready has, so the duplicated-fragment gate reported the helper itself as new duplication while other copies remained. #5885 routes the same six copies, and the remaining copies of the same reading, through the trait instead.AI-assisted: prepared with Claude Code (claude-opus-5-5); reviewed by a maintainer before merge.
Generated by Claude Code